Thread (24 messages) 24 messages, 4 authors, 2019-01-18

Re: [PATCH net 3/7] virtio_net: Fix not restoring real_num_rx_queues

From: Jason Wang <jasowang@redhat.com>
Date: 2019-01-17 12:40:08

On 2019/1/17 下午7:20, Toshiaki Makita wrote:
quoted hunk ↗ jump to hunk
When _virtnet_set_queues() failed we did not restore real_num_rx_queues.
Fix this by placing the change of real_num_rx_queues after
_virtnet_set_queues().
This order is also in line with virtnet_set_channels().

Fixes: 4941d472bf95 ("virtio-net: do not reset during XDP set")
Signed-off-by: Toshiaki Makita <redacted>
---
  drivers/net/virtio_net.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 7d35e6d..670cc15 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -2427,10 +2427,10 @@ static int virtnet_xdp_set(struct net_device *dev, struct bpf_prog *prog,
  		}
  	}
  
-	netif_set_real_num_rx_queues(dev, curr_qp + xdp_qp);
  	err = _virtnet_set_queues(vi, curr_qp + xdp_qp);
  	if (err)
  		goto err;
+	netif_set_real_num_rx_queues(dev, curr_qp + xdp_qp);
  	vi->xdp_queue_pairs = xdp_qp;
  
  	for (i = 0; i < vi->max_queue_pairs; i++) {

Acked-by: Jason Wang <jasowang@redhat.com>

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help