Thread (7 messages) 7 messages, 2 authors, 2019-01-09

Re: [PATCH net 1/5] net: stmmac: Fix PCI module removal leak

From: kbuild test robot <hidden>
Date: 2019-01-09 01:43:58

Hi Jose,

I love your patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/Jose-Abreu/net-stmmac-Misc-fixes/20190109-071238
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c: In function 'stmmac_pci_remove':
quoted
drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:306:19: error: 'PCI_STD_RESOURCE_LEN' undeclared (first use in this function); did you mean 'PCI_STD_RESOURCE_END'?
     for (i = 0; i <= PCI_STD_RESOURCE_LEN; i++) {
                      ^~~~~~~~~~~~~~~~~~~~
                      PCI_STD_RESOURCE_END
   drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:306:19: note: each undeclared identifier is reported only once for each function it appears in

vim +306 drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c

   292	
   293	/**
   294	 * stmmac_pci_remove
   295	 *
   296	 * @pdev: platform device pointer
   297	 * Description: this function calls the main to free the net resources
   298	 * and releases the PCI resources.
   299	 */
   300	static void stmmac_pci_remove(struct pci_dev *pdev)
   301	{
   302		int i;
   303	
   304		stmmac_dvr_remove(&pdev->dev);
   305	
 > 306		for (i = 0; i <= PCI_STD_RESOURCE_LEN; i++) {
   307			if (pci_resource_len(pdev, i) == 0)
   308				continue;
   309			pcim_iounmap_regions(pdev, BIT(i));
   310			break;
   311		}
   312	
   313		pci_disable_device(pdev);
   314	}
   315	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help