Re: [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm
From: <hidden>
Date: 2018-12-29 07:09:10
Also in:
linuxppc-dev
Hi David， Thank you, we'll fix it soon. Best wishes, Wen ------------------Original Mail------------------ Sender: DavidMiller [off-list ref] To: peng hao10096742; CC: qiang.zhao@nxp.com <qiang.zhao@nxp.com>leoyang.li@nxp.com <redacted>linux-kernel@vger.kernel.org <redacted>wen yang10156314;julia.lawall@lip6.fr <redacted>netdev@vger.kernel.org <redacted>linuxppc-dev@lists.ozlabs.org <redacted> Date: 2018/12/29 13:11 Subject: Re: [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm From: Peng Hao <redacted> Date: Wed, 26 Dec 2018 16:26:29 +0800
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c index 839fa77..8ce4921f 100644 --- a/drivers/net/wan/fsl_ucc_hdlc.c +++ b/drivers/net/wan/fsl_ucc_hdlc.c@@ -1057,6 +1057,27 @@ static const struct net_device_ops uhdlc_ops = { .ndo_tx_timeout = uhdlc_tx_timeout, }; +static int ucc_get_resource_by_nodename(char *name, struct resource *res) +{
...
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + return 0;
This assignment to 'res' doesn't do what you think it does. The caller never sees the value you compute.