Re: [PATCH] batman-adv/main: Fix check on return value of rtnl_link_register
From: Sven Eckelmann <hidden>
Date: 2018-12-24 18:43:15
Also in:
batman, lkml
On Monday, 24 December 2018 18.49.26 CET Aditya Pakki wrote: [...]
quoted hunk ↗ jump to hunk
diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c index 69c0d85bceb3..e0007f242823 100644 --- a/net/batman-adv/main.c +++ b/net/batman-adv/main.c@@ -109,7 +109,10 @@ static int __init batadv_init(void) batadv_debugfs_init(); register_netdevice_notifier(&batadv_hard_if_notifier); - rtnl_link_register(&batadv_link_ops); + ret = rtnl_link_register(&batadv_link_ops); + if (ret < 0) + return ret; + batadv_netlink_register();
Uhm, but shouldn't the already initialized parts be unregistered/uninitialized in this case? Rejecting this patch because this could cause a new bug. Also "Fixes: " line is missing Kind regards, Sven
Attachments
- signature.asc [application/pgp-signature] 833 bytes