Re: [PATCH] nfc: af_nfc: Fix Spectre v1 vulnerability
From: Gustavo A. R. Silva <hidden>
Date: 2018-12-22 23:37:43
Also in:
linux-wireless, lkml
From: Gustavo A. R. Silva <hidden>
Date: 2018-12-22 23:37:43
Also in:
linux-wireless, lkml
On 12/22/18 5:09 PM, David Miller wrote:
From: "Gustavo A. R. Silva" <redacted> Date: Fri, 21 Dec 2018 15:47:53 -0600quoted
proto is indirectly controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. This issue was detected with the help of Smatch: net/nfc/af_nfc.c:42 nfc_sock_create() warn: potential spectre issue 'proto_tab' [w] (local cap) Fix this by sanitizing proto before using it to index proto_tab. Notice that given that speculation windows are large, the policy is to kill the speculation on the first load and not worry if it can be completed with a dependent load/store [1]. [1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2 Signed-off-by: Gustavo A. R. Silva <redacted>I'll take this directly, and queued up for -stable.
Dave, I wonder if you can take this one too: https://lore.kernel.org/lkml/20181221212229.GA32635@embeddedor/ (local) It's pretty similar to the af_nfc one. Thanks -- Gustavo