Thread (15 messages) flat view 15 messages, 5 authors, 2018-12-25

Re: [PATCH 4/7] selftest/bpf: test_offload PEP8 format style fix

From: Jakub Kicinski <hidden>
Date: 2018-12-12 18:41:07
Also in: lkml

On Tue, 11 Dec 2018 20:56:04 +0900, Alice Ferrazzi wrote:
Signed-off-by: Alice Ferrazzi <redacted>
Thanks, are you just running pylint to catch those?  I tried in the
past but it's very noisy and it lacked "understanding" of some python3
modules.  Would you mind giving us a quick 101 of how to catch such
errors? :)
-def bpf_obj(name, sec=".text", path=bpf_test_dir,):
+
+def bpf_obj(name, sec=".text", path=bpf_test_dir, ):
     return "obj %s sec %s" % (os.path.join(path, name), sec)
 
I think this one is just a typo.  bpf_obj() seems to always get called
with one param, no?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help