Thread (5 messages) flat view 5 messages, 4 authors, 2018-12-11

Re: [PATCH net-next] ieee802154: ca8210: fix possible u8 overflow in ca8210_rx_done

From: Stefan Schmidt <stefan@datenfreihafen.org>
Date: 2018-12-11 08:27:11
Also in: lkml

Hello Dave.

On 11.12.18 07:01, David Miller wrote:
From: YueHaibing <redacted>
Date: Tue, 11 Dec 2018 11:13:39 +0800
quoted
gcc warning this:

drivers/net/ieee802154/ca8210.c:730:10: warning:
 comparison is always false due to limited range of data type [-Wtype-limits]

'len' is u8 type, we get it from buf[1] adding 2, which can overflow.
This patch change the type of 'len' to unsigned int to avoid this,also fix
the gcc warning.

Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver")
Signed-off-by: YueHaibing <redacted>
WPAN maintainers, I am assuming that as maintainers you will be
picking this up and sending it to me.
That's correct. On driver patches I always wait 2 days or so to give the
driver maintainer a chance to reply before I go ahead and apply it.

I will take this one directly now and do some smoke testing. It will
come together with another fix as pull request to you.

regards
Stefan Schmidt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help