Thread (13 messages) flat view 13 messages, 5 authors, 2018-12-10

Re: linux-next: Signed-off-by missing for commits in the net-next tree

From: David Miller <davem@davemloft.net>
Date: 2018-12-10 00:28:08
Also in: linux-next, lkml

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sun, 9 Dec 2018 22:33:10 +0100
On 09.12.2018 22:11, Andrew Lunn wrote:
quoted
On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote:
quoted
Hi all,

Commits

  dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data")
  04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask")

are missing a Signed-off-by from their author.
Hi David.

Any idea what happened here? The version in my git repo has SOB.

https://patchwork.ozlabs.org/patch/1009811/ also has my SOB.
Instead of
v2
--
int -> u32 in platform data structure

Signed-off-by: Andrew Lunn <andrew@lunn.ch>

shouldn't it be

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
v2
- int -> u32 in platform data structure
No, I want the changelog to actually appear in the commit message.

I'm kinda tired of saying this.

Keep changelog information in the commit message, everyone.

The problem here is the '--' delimiter, Andrew should have either
used nothing or something else.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help