Re: [RFC 3/3] virtio_ring: use new vring flags
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2018-12-07 18:10:58
Also in:
lkml
On Fri, Dec 07, 2018 at 04:48:42PM +0800, Tiwei Bie wrote:
quoted hunk ↗ jump to hunk
Switch to using the _SPLIT_ and _PACKED_ variants of vring flags in split ring and packed ring respectively. Signed-off-by: Tiwei Bie <redacted> ---@@ -502,7 +505,8 @@ static inline int virtqueue_add_split(struct virtqueue *_vq, } } /* Last one doesn't continue. */ - desc[prev].flags &= cpu_to_virtio16(_vq->vdev, ~VRING_DESC_F_NEXT); + desc[prev].flags &= cpu_to_virtio16(_vq->vdev, + (u16)~BIT(VRING_SPLIT_DESC_F_NEXT)); if (indirect) { /* Now that the indirect table is filled in, map it. */
I kind of dislike it that this forces use of a cast here. Kind of makes it more fragile. Let's use a temporary instead?
-- 2.17.1