Thread (4 messages) 4 messages, 4 authors, 2019-01-01

Re: [PATCH iproute2-next] bridge: fdb: Use 'struct ndmsg' for FDB dumping

From: David Ahern <hidden>
Date: 2018-12-31 01:03:50

On 12/30/18 10:14 AM, Ido Schimmel wrote:
Since commit aea41afcfd6d ("ip bridge: Set NETLINK_GET_STRICT_CHK on
socket") iproute2 uses strict checking on kernels that support it. This
causes FDB dumping to fail [1], as iproute2 uses 'struct ifinfomsg'
whereas the kernel expects 'struct ndmsg'.

Note that with this change iproute2 continues to work on old kernels
that do not support strict checking, but contain the fix introduced in
kernel commit bd961c9bc664 ("rtnetlink: fix rtnl_fdb_dump() for ndmsg
header").

[1]
# bridge fdb show
[ 5365.137224] netlink: 4 bytes leftover after parsing attributes in process `bridge'.
Error: bytes leftover after parsing attributes.
Dump terminated

Fixes: aea41afcfd6d ("ip bridge: Set NETLINK_GET_STRICT_CHK on socket")
Signed-off-by: Ido Schimmel <redacted>
---
 bridge/fdb.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
applied to iproute2-next. Thanks, Ido.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help