RE: [PATCH mlx5-next] IB/mlx5: Prevent allocating UMEM and UCTX as some general object

Great, thanks


-----Original Message-----
From: Jason Gunthorpe <jgg@ziepe.ca> 
Sent: Thursday, December 20, 2018 11:02 PM
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <redacted>; Yishai Hadas <redacted>; RDMA mailing list <redacted>; Achiad Shochat <redacted>; Saeed Mahameed <redacted>; linux-netdev <redacted>; Leon Romanovsky <redacted>
Subject: Re: [PATCH mlx5-next] IB/mlx5: Prevent allocating UMEM and UCTX as some general object

On Wed, Dec 19, 2018 at 04:28:15PM +0200, Leon Romanovsky wrote:

From: Yishai Hadas <redacted>

The driver needs to prevent a user space application to create a UMEM 
and UCTX via the general object command.

The UMEM must go through the kernel UMEM_REG method to prevent the 
user from setting physical addresses by himself.  The UCTX is some 
internal kernel object and shouldn't be exposed.

As of not being any more part of the general object the caps bits were 
moved to be some log_xxx indication in the general HCA caps, 0 means 
not supported.

The firmware code was adapted as well to match the above.

Signed-off-by: Yishai Hadas <redacted>
Reviewed-by: Achiad Shochat <redacted>
Signed-off-by: Leon Romanovsky <redacted>
---
 drivers/infiniband/hw/mlx5/devx.c | 34 ++++++++---------  
drivers/infiniband/hw/mlx5/main.c |  3 +-
 include/linux/mlx5/mlx5_ifc.h     | 62 +++++++++++++++++++++----------
 3 files changed, 58 insertions(+), 41 deletions(-)

Applied to for-next

Thanks,
Jason