Thread (12 messages) 12 messages, 2 authors, 2018-12-21

Re: [PATCH net-next v5 RFC 0/8] devlink: Add configuration parameters support for devlink_port

From: Vasundhara Volam <hidden>
Date: 2018-12-21 04:37:37

On Thu, Dec 20, 2018 at 11:25 PM Jakub Kicinski
[off-list ref] wrote:
On Thu, 20 Dec 2018 14:40:11 +0530, Vasundhara Volam wrote:
quoted
This patchset adds support for configuration parameters setting through
devlink_port.  Each device registers supported configuration parameters
table.

The user can retrieve data on these parameters by
"devlink port param show" command and can set new value to a
parameter by "devlink port param set" command.
All configuration modes supported by devlink_dev are supported
by devlink_port also.

Command examples and output:

# devlink port param show
pci/0000:3b:00.0/0:
  name wake-on-lan type generic
    values:
      cmode permanent value false

pci/0000:3b:00.1/1:
  name wake-on-lan type generic
    values:
      cmode permanent value false

pci/0000:af:00.0/0:
  name wake-on-lan type generic
    values:
      cmode permanent value true

# devlink port param show pci/0000:3b:00.0/0 name wake-on-lan
pci/0000:3b:00.0/0:
  name wake-on-lan type generic
    values:
      cmode permanent value false

# devlink port param set pci/0000:3b:00.0/0 name wake-on-lan cmode permanent value true

There is difference of opinion on adding WOL parameter to devlink, between
Jakub Kicinski and Michael Chan.

Quote from Jakud Kicinski:
--------
Patchwork or git may cut off anything under the ------ line.
Thank you. I will resend the patchset by replacing it with ****.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help