Thread (3 messages) flat view 3 messages, 2 authors, 2018-12-21

Re: [PATCH iproute2 1/1] testsuite: Fix colorize

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2018-12-21 04:17:51

On Tue, 18 Dec 2018 20:29:04 +0100
Petr Vorel [off-list ref] wrote:
bash and dash require for escape sequence to use 'echo -e' or printf
(but working on zsh). Choosing printf as it's implementation is IMHO
more portable than echo implementations.
dash also require to use \033[0; as escape sequence instead of \e[0;

NOTE: \e[0; kept in lib/color.c as it's not problematic for C code
(working when run ip on various shells).

Fixes: 7e2f71b4 ("testsuite: colorize test result output")

Signed-off-by: Petr Vorel <pvorel@suse.cz>
Sure applied. Not sure why people expect tests to work without
bash. Next they will want it to work with clang on BSD...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help