Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

quoted

quoted

+static int tja11xx_config_init(struct phy_device *phydev)
+{
+	int ret;
+
+	ret = tja11xx_enable_reg_write(phydev);
+	if (ret)
+		return ret;
+
+	phydev->irq = PHY_POLL;
+	phydev->autoneg = AUTONEG_DISABLE;
+	phydev->speed = SPEED_100;

One more thing: In the data sheet there are SPEED_SELECT bits allowing
to set also 10MBit and 1GBit mode. Don't you want to support this?

Hi Heiner

Did you read footnote 2?

Speed Select. 00: 10 Mbits; 01: 100Mbit/s, 10: 1000Mbit/s, 11:
reserved. a write access value other than 01 is ignored.

So the bits are there, but not really used. It can only do 100Mbit/s.

   Andrew