Re: [PATCH bpf-next v2 1/2] libbpf: add support for using AF_XDP sockets
From: Alexei Starovoitov <hidden>
Date: 2018-12-13 06:23:24
On Wed, Dec 12, 2018 at 02:09:48PM +0100, Magnus Karlsson wrote:
quoted hunk ↗ jump to hunk
diff --git a/tools/lib/bpf/libbpf.map b/tools/lib/bpf/libbpf.map index cd02cd4..ae4cc0d 100644 --- a/tools/lib/bpf/libbpf.map +++ b/tools/lib/bpf/libbpf.map@@ -121,6 +121,15 @@ LIBBPF_0.0.1 { libbpf_prog_type_by_name; libbpf_set_print; libbpf_strerror; + xsk__peek_cons; + xsk__release_cons; + xsk__reserve_prod; + xsk__submit_prod; + xsk__get_data; + xsk__create_umem; + xsk__create_xdp_socket; + xsk__delete_umem; + xsk__delete_xdp_socket; local:
I fully support the idea to provide common library for AF_XDP that is easily available in the distros. The main question is whether AF_XDP warrants its own lib or piggy back on libbpf effort is acceptable. Do you think above set of APIs will be enough for foreseeable future or this is just a beginning? If above is enough then it falls into XDP category. libbpf already has minimal support for XDP and AF_XDP fits right in. But if AF_XDP will keep growing a lot then it would make sense to keep the functionality in a separate library that minimally depends on libbpf.