RE: [PATCH] VSOCK: bind to random port for VMADDR_PORT_ANY

From: Stefan Hajnoczi <stefanha@redhat.com>
Sent: Tuesday, December 11, 2018 8:27 AM
To: Jorgen Hansen <redacted>; Dexuan Cui
[off-list ref]
Cc: netdev@vger.kernel.org; Lepton Wu <redacted>
Subject: Re: [PATCH] VSOCK: bind to random port for VMADDR_PORT_ANY

On Mon, Dec 10, 2018 at 11:02:35PM -0800, Lepton Wu wrote:

quoted

The old code always starts from fixed port for VMADDR_PORT_ANY.

Sometimes

quoted

when VMM crashed, there is still orphaned vsock which is waiting for
close timer, then it could cause connection time out for new started VM
if they are trying to connect to same port with same guest cid since the
new packets could hit that orphaned vsock. We could also fix this by doing
more in vhost_vsock_reset_orphans, but any way, it should be better to start
from a random local port instead of a fixed one.

Signed-off-by: Lepton Wu <redacted>
---
 net/vmw_vsock/af_vsock.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Jorgen, Dexuan: Any objection to this?  It also affects the other
AF_VSOCK transports.

Thanks for letting me notice the patch. :-)

Now I saw Lepton's v2 patch, which looks good to me. 

Thanks,
-- Dexuan