Thread (14 messages) 14 messages, 5 authors, 2018-12-17

Re: [PATCH bpf-next 2/2] samples/bpf: convert xdpsock to use libbpf for AF_XDP access

From: Magnus Karlsson <hidden>
Date: 2018-12-12 07:57:23

Thanks Jakub,

I will mention this in the commit message of the v2.

/Magnus

On Tue, Dec 11, 2018 at 2:08 AM Jakub Kicinski
[off-list ref] wrote:
On Mon, 10 Dec 2018 16:34:45 +0100, Magnus Karlsson wrote:
quoted
diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c
index 57ecadc..ca94cfb 100644
--- a/samples/bpf/xdpsock_user.c
+++ b/samples/bpf/xdpsock_user.c
@@ -44,15 +44,8 @@
 #define PF_XDP AF_XDP
 #endif

-#define NUM_FRAMES 131072
-#define FRAME_HEADROOM 0
-#define FRAME_SHIFT 11
-#define FRAME_SIZE 2048
-#define NUM_DESCS 1024
-#define BATCH_SIZE 16
-
-#define FQ_NUM_DESCS 1024
-#define CQ_NUM_DESCS 1024
+#define NUM_FRAMES (4 * 1024)
+#define BATCH_SIZE 64
nit: small changes to the defines are not mentioned in the commit msg
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help