Thread (38 messages) flat view 38 messages, 8 authors, 2018-12-13

Re: [PATCH net-next 13/13] net: switch secpath to use skb extension infrastructure

From: Steffen Klassert <steffen.klassert@secunet.com>
Date: 2018-12-11 08:06:09

On Mon, Dec 10, 2018 at 03:50:06PM +0100, Florian Westphal wrote:
quoted hunk ↗ jump to hunk
 }
@@ -552,11 +517,6 @@ void __init xfrm_input_init(void)
 	if (err)
 		gro_cells.cells = NULL;
 
-	secpath_cachep = kmem_cache_create("secpath_cache",
-					   sizeof(struct sec_path),
-					   0, SLAB_HWCACHE_ALIGN|SLAB_PANIC,
-					   NULL);
This is not so nice. Usually we need a secpath per packet for IPsec.
With removing the cache, we have to kmalloc a secpath for each packet.
This might have some performance impact.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help