Thread (1 message) flat view 1 message, 1 author, 2018-12-04

RE: [PATCH] intel: ice: Do not enable NAPI on q_vectors that have no rings

From: Bowers, AndrewX <hidden>
Date: 2018-12-04 17:01:26
Also in: intel-wired-lan

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On
Behalf Of Yang Xiao
Sent: Wednesday, November 28, 2018 5:54 PM
To: Kirsher, Jeffrey T <redacted>; davem@davemloft.net
Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; Yang Xiao
[off-list ref]
Subject: [Intel-wired-lan] [PATCH] intel: ice: Do not enable NAPI on
q_vectors that have no rings

From: Young Xiao <redacted>

If ice driver has q_vectors w/ active NAPI that has no rings, then this will
result in a divide by zero error. To correct it I am updating the driver code so
that we only support NAPI on q_vectors that have 1 or more rings allocated
to them.

See commit 13a8cd191a2b ("i40e: Do not enable NAPI on q_vectors that have
no rings") for detail.

Signed-off-by: Young Xiao <redacted>
---
 drivers/net/ethernet/intel/ice/ice_main.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)
Tested-by: Andrew Bowers <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help