Re: [PATCHv3 bpf 1/2] bpf: Support sk lookup in netns with id 0

On Fri, Nov 30, 2018 at 02:36:57PM -1000, Joey Pabalinas wrote:

On Fri, Nov 30, 2018 at 03:32:20PM -0800, Joe Stringer wrote:

quoted

+ *		the netns associated with the *ctx*. *netns* values beyond the
+ *		range of 32-bit integers are reserved for future use.

Would adding a word or two before "*netns*" here be helpful to placate
the english pedants among us (such as myself)? Starting a sentence with
a lowercase word, even if it's a variable name, just never really sits
right with me.

	Any *netns* values ...

Doesn't that kind of flow a bit better anyway?

Hah,

Anyway, now with that unimportant nitpick if off my chest, the rest

                                            ^
                                            |
I make an absolutely terrible pedant. ------

-- 
Cheers,
Joey Pabalinas