Re: [PATCH v2 14/14] nvme-tcp: add NVMe over TCP host driver
From: Sagi Grimberg <sagi@grimberg.me>
Date: 2018-11-21 00:10:31
Also in:
linux-block, linux-nvme
From: Sagi Grimberg <sagi@grimberg.me>
Date: 2018-11-21 00:10:31
Also in:
linux-block, linux-nvme
Hi Sagi,quoted
+ icreq->pfv = cpu_to_le16(NVME_TCP_PFV_1_0); + icreq->maxr2t = cpu_to_le16(1); /* single inflight r2t supported */ + icreq->hpda = 0; /* no alignment constraint */The NVMe-TCP spec indicates that MAXR2T is a 0's-based value. To support a single inflight R2T as indicated in the comment above, icreq->maxr2t should be set to 0, right?
Correct, will fix in the next spin. Thanks