Re: [PATCH 10/11] nvmet-tcp: add NVMe over TCP target driver
From: Sagi Grimberg <sagi@grimberg.me>
Date: 2018-11-19 23:24:18
Also in:
linux-block, linux-nvme
From: Sagi Grimberg <sagi@grimberg.me>
Date: 2018-11-19 23:24:18
Also in:
linux-block, linux-nvme
quoted
Also, looking a bit closer there is a slight difference between the copy vs. the copy_and_csum variants. copy allows for a short_copy if we copy less than we expect while the csum faults it. I'm thinking that the copy_and_hash variant should also fault? Although I'm not sure I understand the fault entirely as csum is supposed to be cumulative, any insight?When we are writing and signal an error, sockets have this recurring pattern where we return immediately the amount of bytes successfully transferred. Then on the next sendmsg() call we give the error. I don't know if that is what is influencing the behavior here or not but it could be.
That makes sense... Does recvmsg() have the same semantics? this is the rx path where we copy fragments to an iter.. If so, I guess that it makes sense that we fault and not allow short copies as we have an incomplete csum in this case... I'm wandering how we can consolidate the code paths together with this subtle difference? Perhaps a short_copy flag?