Thread (4 messages) 4 messages, 2 authors, 2018-12-19

linux-next: build warning after merge of the net-next tree

From: Stephen Rothwell <hidden>
Date: 2018-11-29 00:24:33
Also in: linux-next, lkml

Hi all,

After merging the net-next tree, today's linux-next build
(x86_64_allmodconfig) produced this warning:

drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c: In function 'run_xdp':
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:324:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
   bpf_warn_invalid_xdp_action(xdp_act);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:325:2: note: here
  case XDP_ABORTED:
  ^~~~
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:326:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
   trace_xdp_exception(priv->net_dev, xdp_prog, xdp_act);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:327:2: note: here
  case XDP_DROP:
  ^~~~

Introduced by commit

  7e273a8ebdd3 ("dpaa2-eth: Add basic XDP support")

This due to my use of -Wimplicit-fallthrough.  This is new code.  The
warning can be suppressed by adding a comment like /* fall through */
at the appropriate places to indicate that the fallthrough is intended.

-- 
Cheers,
Stephen Rothwell

Attachments

  • (unnamed) [application/pgp-signature] 488 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help