Re: [PATCH] net: stmmac: Move debugfs init/exit to ->probe()/->remove()
From: Jose Abreu <jose.abreu@synopsys.com>
Date: 2018-11-23 12:44:11
Also in:
linux-tegra, lkml
On 23-11-2018 12:21, Thierry Reding wrote:
From: Thierry Reding <redacted>
Setting up and tearing down debugfs is current unbalanced, as seen by
this error during resume from suspend:
[ 752.134067] dwc-eth-dwmac 2490000.ethernet eth0: ERROR failed to create debugfs directory
[ 752.134347] dwc-eth-dwmac 2490000.ethernet eth0: stmmac_hw_setup: failed debugFS registration
The imbalance happens because the driver creates the debugfs hierarchy
when the device is opened and tears it down when the device is closed.
There's little gain in that, and it could be argued that it is even
surprising because it's not usually done for other devices. Fix the
imbalance by moving the debugfs creation and teardown to the driver's
->probe() and ->remove() implementations instead.
Signed-off-by: Thierry Reding <redacted>
---Did you test trying to dump "descriptors_status" file when interface is not open ? I think that's the main reason why this is not in probe ... Thanks and Best Regards, Jose Miguel Abreu