Re: [PATCH 1/4] net-next/hinic:replace multiply and division operators
From: David Miller <davem@davemloft.net>
Date: 2018-11-19 23:01:47
Also in:
lkml
From: Xue Chaojing <redacted> Date: Mon, 19 Nov 2018 06:12:31 +0000
quoted hunk ↗ jump to hunk
@@ -530,7 +536,9 @@ int hinic_wq_allocate(struct hinic_wqs *wqs, struct hinic_wq *wq, return -EINVAL; } - num_wqebbs_per_page = ALIGN(wq_page_size, wqebb_size) / wqebb_size; + wqebb_size_shift = ilog2(wqebb_size);
You now have introduced the assumption that these various sizes are a power of two. You should check for this, either at compile time or at run time, in order to avoid surprises and hard to debug issues in the future. Thank you.