Thread (37 messages) 37 messages, 7 authors, 2018-12-06

Re: [PATCH v2 11/25] net: cadence: switch to using nvmem_get_mac_address()

From: <Nicolas.Ferre@microchip.com>
Date: 2018-11-18 15:42:41
Also in: linux-arm-kernel, linux-devicetree, linux-i2c, linux-omap, lkml

On 13/11/2018 at 15:01, Bartosz Golaszewski wrote:
From: Bartosz Golaszewski <redacted>

We now have a generalized helper routine to read the MAC address from
nvmem which takes struct device as argument. The nvmem subsystem will
then try device tree first before all other potential providers.

Signed-off-by: Bartosz Golaszewski <redacted>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
quoted hunk ↗ jump to hunk
---
  drivers/net/ethernet/cadence/macb_main.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 1d86b4d5645a..d9a208f7bb40 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4055,7 +4055,7 @@ static int macb_probe(struct platform_device *pdev)
  	if (mac) {
  		ether_addr_copy(bp->dev->dev_addr, mac);
  	} else {
-		err = of_get_nvmem_mac_address(np, bp->dev->dev_addr);
+		err = nvmem_get_mac_address(&pdev->dev, bp->dev->dev_addr);
  		if (err) {
  			if (err == -EPROBE_DEFER)
  				goto err_out_free_netdev;

-- 
Nicolas Ferre
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help