Re: RFC: changed error code when binding unix socket twice
From: Petr Vorel <pvorel@suse.cz>
Date: 2018-11-07 15:56:51
Also in:
lkml, ltp
From: Petr Vorel <pvorel@suse.cz>
Date: 2018-11-07 15:56:51
Also in:
lkml, ltp
Hi
I forgot that 4.1 has ended a while ago. Greg also sometimes still takes patches for 3.18, so that might be a candidate aside from 3.18
Gregkh, David, does it make sense to you to merge commit 0fb44559ffd6 ("af_unix:
move unix_mknod() out of bindlock") to 3.18? If yes, please do so.
quoted
I guess we need to adjust LTP test to accept either return code as EOL longterm branches probably will not take this patch.
I'd argue that if we decide that EADDRINUSE is the intended return value, it would be appropriate for LTP to warn about kernels that never got the backport.
The alternative would be to not backport the patch further, and then change LTP to no longer warn. Note that the bug that got fixed by the 0fb44559ffd6 patch is probably more important than the return code, so I would say we want the patch backported to anything that people still run anyway, especially if they are running LTP to make sure it works correctly.
Arnd
Kind regards, Petr