On Tue, Nov 27, 2018 at 5:11 PM Saeed Mahameed [off-list ref] wrote:

On Tue, 2018-11-27 at 16:07 -0800, Cong Wang wrote:

quoted

On Tue, Nov 27, 2018 at 3:48 PM Eric Dumazet [off-list ref]
wrote:

quoted

The bug here is that mlx5 csum only includes the data in IP frame.

I would simply force skb->ip_summed to CHECKSUM_NONE if any padding
is detected.

Totally agree, let's just skip csum completes for very small packets
( < ETH_ZLEN ).

That is my first idea in my mind, but you know we still have to parse IP header
to detect packets < ETH_ZLEN. Essentially same work, only saves a few adds
in csum_add(). ;)