Re: [PATCH net-next,v3 03/12] flow_dissector: add flow action infrastructure
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2018-11-22 15:25:31
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2018-11-22 15:25:31
On 11/20/2018 6:51 PM, Pablo Neira Ayuso wrote:
This new infrastructure defines the nic actions that you can perform from existing network drivers. This infrastructure allows us to avoid a direct dependency with the native software TC action representation. Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> ---
[snip]
+#define flow_action_for_each(__i, __act, __actions) \ + for (__i = 0, __act = &(__actions)->entries[0]; __i < (__actions)->num_entries; __act = &(__actions)->entries[++__i])
Post increment is more common in for_each* constructs, any reason why you are you using a pre increment here? -- Florian