Re: [PATCH net] sctp: not increase stream's incnt before sending addstrm_in request
From: David Miller <davem@davemloft.net>
Date: 2018-11-20 09:13:19
Also in:
linux-sctp
From: David Miller <davem@davemloft.net>
Date: 2018-11-20 09:13:19
Also in:
linux-sctp
From: Xin Long <lucien.xin@gmail.com> Date: Sun, 18 Nov 2018 21:59:49 +0800
Different from processing the addstrm_out request, The receiver handles
an addstrm_in request by sending back an addstrm_out request to the
sender who will increase its stream's in and incnt later.
Now stream->incnt has been increased since it sent out the addstrm_in
request in sctp_send_add_streams(), with the wrong stream->incnt will
even cause crash when copying stream info from the old stream's in to
the new one's in sctp_process_strreset_addstrm_out().
This patch is to fix it by simply removing the stream->incnt change
from sctp_send_add_streams().
Fixes: 242bd2d519d7 ("sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter")
Reported-by: Jianwen Ji <redacted>
Signed-off-by: Xin Long <lucien.xin@gmail.com>Applied and queued up for -stable.