Re: [PATCH net-next,v2 09/12] flow_dissector: add basic ethtool_rx_flow_spec to flow_rule structure translator
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2018-11-20 01:07:37
On Mon, Nov 19, 2018 at 03:17:43PM +0100, Jiri Pirko wrote:
Mon, Nov 19, 2018 at 01:15:16AM CET, pablo@netfilter.org wrote:
[...]
quoted
diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h index 7a4683646d5a..ec9036232538 100644 --- a/include/net/flow_dissector.h +++ b/include/net/flow_dissector.h
[...]
quoted
+struct flow_rule *ethtool_rx_flow_rule(const struct ethtool_rx_flow_spec *fs)
[...]
Code that is doing ethtool->flow_rule conversion should be in ethtool code. You should just provide helpers here (in flow.c) that could be used to assemble the flow_rule structure.
OK, will place this in ethtool file.