Re: [PATCH V2 net-next 4/5] net: mdio: of: Register discovered MII time stampers.

On Sun, Oct 07, 2018 at 12:26:27PM -0700, Richard Cochran wrote:

On Sun, Oct 07, 2018 at 08:17:54PM +0200, Andrew Lunn wrote:

quoted

quoted

quoted

+	if (err == -ENOENT)
+		return NULL;
+	else if (err)
+		return ERR_PTR(err);
+
+	if (args.args_count >= 1)
+		port = args.args[0];

If it's greater than one, than it is an error, and it should be flagged
as such.

The idea looks good though, should of_find_mii_timestamper() somehow be
made conditional to CONFIG_PTP and we should have a stub for when it is
disabled?

Hi Florian

There already is a stub. But register return -EOPNOTSUPP.

The stub returns NULL...

Ah, sorry, it is register_mii_tstamp_controller() which return
-EOPNOTSUP.

	Andrew