Thread (4 messages) flat view 4 messages, 3 authors, 2018-10-09

Re: [PATCH net-next] net/ipv6: stop leaking percpu memory in fib6 info

From: David Ahern <hidden>
Date: 2018-10-08 18:15:54
Also in: stable

On 10/8/18 6:06 AM, Mike Rapoport wrote:
quoted hunk ↗ jump to hunk
The fib6_info_alloc() function allocates percpu memory to hold per CPU
pointers to rt6_info, but this memory is never freed. Fix it.

Fixes: a64efe142f5e ("net/ipv6: introduce fib6_info struct and helpers")

Signed-off-by: Mike Rapoport <redacted>
Cc: stable@vger.kernel.org
---
 net/ipv6/ip6_fib.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
index cf709eadc932..cc7de7eb8b9c 100644
--- a/net/ipv6/ip6_fib.c
+++ b/net/ipv6/ip6_fib.c
@@ -194,6 +194,8 @@ void fib6_info_destroy_rcu(struct rcu_head *head)
 				*ppcpu_rt = NULL;
 			}
 		}
+
+		free_percpu(f6i->rt6i_pcpu);
 	}
 
 	lwtstate_put(f6i->fib6_nh.nh_lwtstate);
Odd that KMEMLEAK is not detecting this. Thanks for the fix.

Reviewed-by: David Ahern <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help