Re: [PATCH] hinic: Fix l4_type parameter in hinic_task_set_tunnel_l4
From: David Miller <davem@davemloft.net>
Date: 2018-10-30 03:43:59
Also in:
lkml
From: David Miller <davem@davemloft.net>
Date: 2018-10-30 03:43:59
Also in:
lkml
From: Nathan Chancellor <redacted> Date: Mon, 29 Oct 2018 03:51:58 -0700
Clang warns:
drivers/net/ethernet/huawei/hinic/hinic_tx.c:392:34: error: implicit
conversion from enumeration type 'enum hinic_l4_tunnel_type' to
different enumeration type 'enum hinic_l4_offload_type'
[-Werror,-Wenum-conversion]
hinic_task_set_tunnel_l4(task, TUNNEL_UDP_NO_CSUM,
~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~
1 error generated.
It seems that hinic_task_set_tunnel_l4 was meant to take an enum of type
hinic_l4_tunnel_type, not hinic_l4_offload_type, given both the name of
the functions and the values used.
Fixes: cc18a7543d2f ("net-next/hinic: add checksum offload and TSO support")
Signed-off-by: Nathan Chancellor <redacted>Applied.