Re: CAKE and r8169 cause panic on upload in v4.19
From: Oleksandr Natalenko <hidden>
Date: 2018-10-28 12:22:15
Also in:
lkml
Hi. On 28.10.2018 05:44, David Miller wrote:
quoted hunk ↗ jump to hunk
Does this fix it?diff --git a/net/core/dev.c b/net/core/dev.c index 022ad73d6253..77d43ae2a7bb 100644 --- a/net/core/dev.c +++ b/net/core/dev.c@@ -5457,7 +5457,7 @@ static void gro_flush_oldest(struct list_head*head) /* Do not adjust napi->gro_hash[].count, caller is adding a new * SKB to the chain. */ - list_del(&oldest->list); + skb_list_del_init(oldest); napi_gro_complete(oldest); }
Yes, but I had to apply both a8305bff6852 and 992cba7e276d too to get it compiled. With these 3 patches the panic is not triggered any more while having GRO enabled. Thanks! -- Oleksandr Natalenko (post-factum)