Re: [PATCH] libertas: remove set but not used variable 'int_type'
From: zhong jiang <hidden>
Date: 2018-10-23 14:28:22
Also in:
linux-wireless, lkml
From: zhong jiang <hidden>
Date: 2018-10-23 14:28:22
Also in:
linux-wireless, lkml
On 2018/10/23 22:23, Lubomir Rintel wrote:
On Tue, 2018-10-23 at 11:32 +0800, zhong jiang wrote:quoted
int_type is not used after setting its value. It is safe to remove the unused variable.Hi. I believe your colleague has sent an equivalent patch a few days ago in [ref]: https://lore.kernel.org/linux-wireless/1539569795-176889-1-git-send-email-yuehaibing@huawei.com/ (local)
I miss that. Thanks, please ignore the patch. Sincerely, zhong jiang
Cheers, Luboquoted
Signed-off-by: zhong jiang <redacted> --- drivers/net/wireless/marvell/libertas/if_spi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/drivers/net/wireless/marvell/libertas/if_spi.cb/drivers/net/wireless/marvell/libertas/if_spi.c index 504d6e0..7c3224b 100644--- a/drivers/net/wireless/marvell/libertas/if_spi.c +++ b/drivers/net/wireless/marvell/libertas/if_spi.c@@ -796,15 +796,13 @@ static void if_spi_h2c(struct if_spi_card*card, { struct lbs_private *priv = card->priv; int err = 0; - u16 int_type, port_reg; + u16 port_reg; switch (type) { case MVMS_DAT: - int_type = IF_SPI_CIC_TX_DOWNLOAD_OVER; port_reg = IF_SPI_DATA_RDWRPORT_REG; break; case MVMS_CMD: - int_type = IF_SPI_CIC_CMD_DOWNLOAD_OVER; port_reg = IF_SPI_CMD_RDWRPORT_REG; break; default:.