Re: [PATCH 19/20] rtlwifi: rtl8821ae: phy: Mark expected switch fall-through
From: Pkshih <pkshih@realtek.com>
Date: 2018-10-23 01:24:31
Also in:
linux-wireless, lkml
On Mon, 2018-10-22 at 22:47 +0200, Gustavo A. R. Silva wrote:
quoted hunk ↗ jump to hunk
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <redacted> --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.cb/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c index 176deb2..a75451c 100644--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c@@ -394,6 +394,7 @@ static void _rtl8812ae_phy_set_rfe_reg_24g(structieee80211_hw *hw) rtl_set_bbreg(hw, RB_RFE_INV, BMASKRFEINV, 0x000); break; } + /* fall through */ case 0: case 2: default:
If BT isn't coexisting in the case 1, the settings will be the same as case 0/2. Acked-by: Ping-Ke Shih <pkshih@realtek.com>