Re: [PATCH net-next] ixgbe: fix XFRM_ALGO dependency

On Wed, Oct 17, 2018 at 5:53 PM Jeff Kirsher
[off-list ref] wrote:

On Tue, 2018-10-16 at 09:35 -0700, Shannon Nelson wrote:

quoted

On 10/16/2018 3:03 AM, Arnd Bergmann wrote:

quoted

A separate Kconfig symbol now controls whether we include the ipsec
offload code. To keep the old behavior, this is left as 'default
y'. The
dependency in XFRM_OFFLOAD still causes a circular dependency but
is
not actually needed because this symbol is not user visible, so
removing
that dependency on top makes it all work.

Fixes: eda0333ac293 ("ixgbe: add VF IPsec management")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I agree with Shannon's suggested changes.  Arnd, are you working on v2?
Or would you like me to take care of it?

I was planning to respin it, but didn't get around to it yet, and will
be travelling for the next week, so I'd welcome if you can take over
from here. Shannon's comments all make sense to me as well.

quoted

quoted

+config IXGBE_IPSEC
+   bool "IPSec XFRM cryptography-offload accelaration"
+   default n

remove this "default n" line?

I meant for this to say "default y", as I said in the changelog,
but feel free to pick whichever default makes sense to you
make make the description match ;-)

Thanks,

       Arnd