Thread (1 message) 1 message, 1 author, 2018-10-15

Re: [PATCH 2/8] usbnet: smsc95xx: add kconfig for turbo mode

From: Bjørn Mork <bjorn@mork.no>
Date: 2018-10-15 12:48:34
Also in: linux-usb, lkml

Ben Dooks [off-list ref] writes:
Add a configuration option for the default state of turbo mode
on the smsc95xx networking driver. Some systems it is better
to default this to off as it causes significant increases in
soft-irq load.

So there is already a module option allowing you to change this, using
e.g kernel command line or kmod config files.  It's even writable,
taking effect on the next netdev open, so you can change it at runtime
without reloading the module.

What good does this new build-time setting do, except causing confusion
wrt driver defaults?

Note also that the smsc95xx and smsc75xx drivers are pretty similar.
Both have the same turbo_mode setting.  If you change the defaults, then
they should at least be kept in sync to cause as little confusion as
possible..




Bjørn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help