Re: [PATCH] virtio_net: enable tx after resuming from suspend
From: Jason Wang <jasowang@redhat.com>
Date: 2018-10-11 09:44:11
Also in:
lkml
On 2018年10月11日 15:51, Ake Koomsin wrote:
quoted hunk ↗ jump to hunk
commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") disabled the virtio tx before going to suspend to avoid a use after free. However, after resuming, it causes the virtio_net device to lose its network connectivity. To solve the issue, we need to enable tx after resuming. Fixes commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") Signed-off-by: Ake Koomsin <redacted> --- drivers/net/virtio_net.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index dab504ec5e50..3453d80f5f81 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c@@ -2256,6 +2256,7 @@ static int virtnet_restore_up(struct virtio_device *vdev) } netif_device_attach(vi->dev); + netif_start_queue(vi->dev);
I believe this is duplicated with netif_tx_wake_all_queues() in netif_device_attach() above? Thanks
return err; }