Thread (7 messages) flat view 7 messages, 4 authors, 2018-10-08

Re: [PATCH] rtlwifi: rtl8821ae: add in a missing break in switch statement

From: Kalle Valo <hidden>
Date: 2018-10-06 19:30:22
Also in: kernel-janitors, linux-wireless, lkml

Colin King [off-list ref] writes:
From: Colin Ian King <redacted>

The switch case RATR_INX_WIRELESS_MC has a missing break, this seems
to be unintentional as the setting of variable ret gets overwritten
when the case falls through to the following RATR_INX_WIRELESS_AC_5N
case.  Fix this by adding in the missing break.

Detected by CoverityScan, CID#1167237 ("Missing break in switch")

Fixes: 3c05bedb5fef ("Staging: rtl8812ae: Add Realtek 8821 PCI WIFI driver")
Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 1 +
Is the fixes line correct? This patch is not for staging.

-- 
Kalle Valo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help