Re: [PATCH bpf-next 1/6] bpf: introduce BPF_PROG_TYPE_FILE_FILTER
From: Andy Lutomirski <luto@amacapital.net>
Date: 2018-10-05 22:09:36
Also in:
lkml
From: Andy Lutomirski <luto@amacapital.net>
Date: 2018-10-05 22:09:36
Also in:
lkml
On Fri, Oct 5, 2018 at 3:05 PM Alexei Starovoitov [off-list ref] wrote:
On Fri, Oct 05, 2018 at 05:46:59AM +0100, Al Viro wrote:quoted
Another problem is your direct poking in ->i_ino. It's not something directly exposed to userland at the moment and it should not become such.The patch is not making i_ino directly exposed. Only 'struct bpf_file_info' is exposed to user space / bpf programs.
I think Al is saying that the valie of i_ino is not something that user code is permitted to know regardless of how you format it because it may or may not actually match the value returned by stat(). Another way of saying that is that your patch is digging into an internal data structure and is doing it wrong. --Andy