Thread (3 messages) flat view 3 messages, 3 authors, 2018-10-13
STALE2901d

[PATCH] net: wireless: iwlegacy: Add a lock assertion in il4965_send_rxon_assoc()

From: Jia-Ju Bai <hidden>
Date: 2018-10-05 13:56:00
Also in: linux-wireless, lkml
Subsystem: intel wireless 3945abg/bg, 4965agn (iwlegacy), the rest · Maintainers: Stanislaw Gruszka, Linus Torvalds

The variables il->staging.filter_flags, rxon1->filter_flags and 
rxon2->filter_flags need to be protected by the mutex lock il->mutex.
This patch adds a lock assertion of il->mutex to check whether 
this lock is held.

Signed-off-by: Jia-Ju Bai <redacted>
---
 drivers/net/wireless/intel/iwlegacy/4965.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/intel/iwlegacy/4965.c b/drivers/net/wireless/intel/iwlegacy/4965.c
index c3c638ed0ed7..ce4144a89217 100644
--- a/drivers/net/wireless/intel/iwlegacy/4965.c
+++ b/drivers/net/wireless/intel/iwlegacy/4965.c
@@ -1297,6 +1297,8 @@ il4965_send_rxon_assoc(struct il_priv *il)
 	const struct il_rxon_cmd *rxon1 = &il->staging;
 	const struct il_rxon_cmd *rxon2 = &il->active;
 
+	lockdep_assert_held(&il->mutex);
+
 	if (rxon1->flags == rxon2->flags &&
 	    rxon1->filter_flags == rxon2->filter_flags &&
 	    rxon1->cck_basic_rates == rxon2->cck_basic_rates &&
-- 
2.17.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help