Thread (1 message) 1 message, 1 author, 2018-10-03

Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

From: Kalle Valo <hidden>
Date: 2018-10-03 08:58:21
Also in: linux-wireless, lkml

Luciano Coelho [off-list ref] writes:
quoted
+#if IS_ENABLED(CONFIG_BT_INTEL)
+		if (firmware_unlock_func) {
+			firmware_unlock_func();
+			symbol_put(btintel_firmware_lock);
+			firmware_lock_func = NULL;
+			symbol_put(btintel_firmware_unlock);
+			firmware_unlock_func = NULL;
+		}
+#endif
+	}
 	else
 		ret = iwl_pcie_load_given_ucode(trans, fw);
 
I'm not sure I like adding this BT-specific stuff here, especially not
without a detailed explanation.
This looks like an ugly hack and the commit log tells nothing. This
really needs strong justifications to even consider doing something like
this.

-- 
Kalle Valo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help