On Tue, Oct 30, 2018 at 11:42 AM Eric Dumazet [off-list ref] wrote:

On Tue, Oct 30, 2018 at 11:09 AM Cong Wang [off-list ref] wrote:

quoted

At least skb_header_pointer() is marked as __must_check, I don't see
you check its return value here.

This can not fail here.

skb->length must be above 14+4 at this point.

Never say it is wrong, just saying what compiler thinks.

My compiler seems to be okay with that.

I wonder how compiler recognizes it as "never fail" when marked with
__must_check.