Re: [PATCH] bpf: tcp_bpf_recvmsg should return EAGAIN when nonblocking and no data
From: John Fastabend <john.fastabend@gmail.com>
Date: 2018-10-30 05:21:26
From: John Fastabend <john.fastabend@gmail.com>
Date: 2018-10-30 05:21:26
On 10/29/2018 12:31 PM, John Fastabend wrote:
We return 0 in the case of a nonblocking socket that has no data available. However, this is incorrect and may confuse applications. After this patch we do the correct thing and return the error EAGAIN. Quoting return codes from recvmsg manpage, EAGAIN or EWOULDBLOCK The socket is marked nonblocking and the receive operation would block, or a receive timeout had been set and the timeout expired before data was received. Signed-off-by: John Fastabend <john.fastabend@gmail.com> ---
Add fixes tag.
Fixes: 604326b41a6f ("bpf, sockmap: convert to generic sk_msg interface")