Thread (32 messages) flat view 32 messages, 4 authors, 2018-10-29

Re: [PATCH v2 05/17] octeontx2-af: Config NPC KPU engines with parser profile

From: Arnd Bergmann <arnd@arndb.de>
Date: 2018-10-26 20:44:12

On 10/22/18, sunil.kovvuri@gmail.com [off-list ref] wrote:
From: Sunil Goutham <sgoutham@marvell.com>
+struct npc_kpu_action0 {
+#if defined(__BIG_ENDIAN_BITFIELD)
+	u64 rsvd_63_57     : 7;
+	u64 byp_count      : 3;
+	u64 capture_ena    : 1;
+	u64 parse_done     : 1;
+	u64 next_state     : 8;
+	u64 rsvd_43        : 1;
+	u64 capture_lid    : 3;
This looks like it again introduces a problem on bit-endian kernels,
since you have fields that span multiple bytes. Could you rewrite
it to avoid the use of bitfields?

    Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help