Thread (3 messages) 3 messages, 3 authors, 2018-10-26

Re: [PATCH v2 bpf] bpf: devmap: fix wrong interface selection in notifier_call

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2018-10-26 07:30:57

On 10/24/2018 01:15 PM, Taehee Yoo wrote:
The dev_map_notification() removes interface in devmap if
unregistering interface's ifindex is same.
But only checking ifindex is not enough because other netns can have
same ifindex. so that wrong interface selection could occurred.
Hence netdev pointer comparison code is added.

v2: compare netdev pointer instead of using net_eq() (Daniel Borkmann)
v1: Initial patch

Fixes: 2ddf71e23cc2 ("net: add notifier hooks for devmap bpf map")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Applied to bpf, thanks Taehee!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help