Re: [PATCH v3 net-next 03/11] net: dsa: microchip: Initialize mutex before use
From: Pavel Machek <hidden>
Date: 2018-10-24 19:35:34
On Mon 2018-10-22 19:26:07, Tristram.Ha@microchip.com wrote:
From: Tristram Ha <redacted> Initialize mutex before use. Signed-off-by: Tristram Ha <redacted>
quoted hunk ↗ jump to hunk
--- drivers/net/dsa/microchip/ksz_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index 8c5853e..88e8d2a 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c@@ -1118,7 +1118,6 @@ static int ksz_switch_init(struct ksz_device *dev) { int i; - mutex_init(&dev->reg_mutex); mutex_init(&dev->stats_mutex); mutex_init(&dev->alu_mutex); mutex_init(&dev->vlan_mutex);@@ -1207,6 +1206,9 @@ int ksz_switch_register(struct ksz_device *dev) if (dev->pdata) dev->chip_id = dev->pdata->chip_id; + /* mutex is used in next function call. */ + mutex_init(&dev->reg_mutex); + if (ksz_switch_detect(dev)) return -EINVAL;
Actually, would it make sense to move all mutex_init's there? No harm in doing them sooner... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachments
- signature.asc [application/pgp-signature] 181 bytes