Re: [PATCH net 1/1] qed: Fix static checker warning
From: David Miller <davem@davemloft.net>
Date: 2018-10-24 02:30:23
From: Rahul Verma <redacted> Date: Tue, 23 Oct 2018 08:04:24 -0700
From: Rahul Verma <redacted> Static Checker Warnings: drivers/net/ethernet/qlogic/qed/qed_main.c:1510 qed_fill_link_capability() error: uninitialized symbol 'tcvr_state'. drivers/net/ethernet/qlogic/qed/qed_mcp.c:1951 qed_mcp_trans_speed_mask() error: uninitialized symbol 'transceiver_state'. drivers/net/ethernet/qlogic/qed/qed_mcp.c:1951 qed_mcp_trans_speed_mask() error: uninitialized symbol 'transceiver_type'. Symbols tcvr_state, transceiver_state and transceiver_type are initialized with respective default state. Fixes: c56a8be7e7aa (qed: Add supported link and advertise link to display in ethtool.)
Referenced commits shall be of the form:
SHA1_ID ("Commit header text.")
Meaning that text must be contained inside of parenthesis and also double quotes.
Please do not forget the double quotes in the future.
Reported-by: Dan Carpenter <redacted> Signed-off-by: Rahul Verma <redacted>
Fixed, and applied. Thanks.